cynthion: init at 0.1.7 #353392
Merged
cynthion: init at 0.1.7 #353392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossless
force-pushed
the
packages/cynthion
branch
2 times, most recently
from
ff4bf2a to
b85b818
Compare
carlossless
commented
Nov 3, 2024
carlossless
force-pushed
the
packages/cynthion
branch
4 times, most recently
from
175fdfa to
7849b81
Compare
ofborg
bot
added
8.has: package (new)
carlossless
force-pushed
the
packages/cynthion
branch
6 times, most recently
from
1806bf8 to
931a394
Compare
carlossless
commented
Nov 12, 2024
There was a problem hiding this comment.
In addition to the question in the line comments, I'm not sure what would be the required way to merge all of these dependency packages. Should they be separate PRs; or separate commits in this single PR; or it's fine to keep this PR single-commit (which was the least effort)
Guidance here would be appreciated!
Please separate commits in this one PR. Thanks. |
carlossless
force-pushed
the
packages/cynthion
branch
from
931a394 to
bcf6ed7
Compare
|
@natsukium I made the changes, please have a look when you can! ~Thanks! |
natsukium
reviewed
Nov 18, 2024
carlossless
force-pushed
the
packages/cynthion
branch
from
bcf6ed7 to
57fb63c
Compare
natsukium
approved these changes
Nov 18, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python package and utilities for the Great Scott Gadgets Cynthion USB Test Instrument https://github.com/greatscottgadgets/cynthion
Packages (dependencies) also included in this PR:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.